Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more support for HTTP copying #148

Open
jskeet opened this issue May 24, 2021 · 0 comments
Open

Add more support for HTTP copying #148

jskeet opened this issue May 24, 2021 · 0 comments
Assignees
@jskeet
Labels
enhancement New feature or request

Comments

@jskeet
Copy link
Contributor

jskeet commented May 24, 2021

Potentially:

  • CloudEvent.CopyToHttpRequestMessage
  • CloudEvent.CopyToHttpResponseMessage
  • HttpContent.ToCloudEvent (may not be terribly useful)
  • HttpWebResponse.ToCloudEvent
  • CloudEvent.CopyToHttpResponse (ASP.NET Core)

We should look at what the current code for each of those would look like, and consider adding extension methods for them.
@jskeet jskeet added the enhancement New feature or request label May 24, 2021
@jskeet jskeet self-assigned this May 24, 2021
@jskeet jskeet mentioned this issue May 24, 2021
Closed
jskeet added a commit to jskeet/sdk-csharp that referenced this issue Jun 29, 2021
@jskeet
Add methods to copy CloudEvents to HttpResponse
0c8cf09 
One part of cloudevents#148

Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet added a commit to jskeet/sdk-csharp that referenced this issue Jun 29, 2021
@jskeet
Add methods to copy CloudEvents to HttpResponse
a205a44 
One part of cloudevents#148

Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet added a commit that referenced this issue Jun 30, 2021
@jskeet
Add methods to copy CloudEvents to HttpResponse
d4ff2b5 
One part of #148

Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet added a commit to jskeet/sdk-csharp that referenced this issue Jul 14, 2021
@jskeet
All packages release version 2.1.0
5993648 
New features:

- Nullable reference type annotations ([cloudevents#170](cloudevents#170))
- More batch support for HttpListener ([cloudevents#166](cloudevents#166))
- CloudEvent.CopyToHttpResponse extension method (part of [cloudevents#148](cloudevents#148))

Other improvements:

- More informative error message for non-CE HTTP requests ([cloudevents#165](cloudevents#165))

Bug fixes:

- Various small XML docs typos ([commit](cloudevents@626089e))
- Don't set the content type to JSON in HttpListener when it's not set in the CloudEvent ([commit](cloudevents@18e1363))

Signed-off-by: Jon Skeet <jonskeet@google.com>
@jskeet jskeet mentioned this issue Jul 14, 2021
Merged
jskeet added a commit that referenced this issue Jul 14, 2021
@jskeet
All packages release version 2.1.0
bedad89 
New features:

- Nullable reference type annotations ([#170](#170))
- More batch support for HttpListener ([#166](#166))
- CloudEvent.CopyToHttpResponse extension method (part of [#148](#148))

Other improvements:

- More informative error message for non-CE HTTP requests ([#165](#165))

Bug fixes:

- Various small XML docs typos ([commit](626089e))
- Don't set the content type to JSON in HttpListener when it's not set in the CloudEvent ([commit](18e1363))

Signed-off-by: Jon Skeet <jonskeet@google.com>
@jskeet jskeet mentioned this issue Feb 9, 2022
Closed
ericdotnet added a commit to ericdotnet/CSharp-sdk-dev that referenced this issue May 13, 2024
@ericdotnet
All packages release version 2.1.0
351589f 
New features:

- Nullable reference type annotations ([#170](cloudevents/sdk-csharp#170))
- More batch support for HttpListener ([#166](cloudevents/sdk-csharp#166))
- CloudEvent.CopyToHttpResponse extension method (part of [#148](cloudevents/sdk-csharp#148))

Other improvements:

- More informative error message for non-CE HTTP requests ([#165](cloudevents/sdk-csharp#165))

Bug fixes:

- Various small XML docs typos ([commit](cloudevents/sdk-csharp@626089e))
- Don't set the content type to JSON in HttpListener when it's not set in the CloudEvent ([commit](cloudevents/sdk-csharp@18e1363))

Signed-off-by: Jon Skeet <jonskeet@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jskeet