Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #155 (removal of Distributed Tracing extension) #228

Open
iampluque opened this issue Aug 3, 2022 · 3 comments
Open

Revert PR #155 (removal of Distributed Tracing extension) #228

iampluque opened this issue Aug 3, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@iampluque
Copy link

As per comment on cloudevent/spec #715, distributed tracing extension should be kept in the spec.

Please revert PR #155

@jskeet
Copy link
Contributor

jskeet commented Aug 3, 2022

I'll have a look when I get a chance, but it probably won't be soon as I'm on vacation for a week starting Friday. Given how extensions have been changing recently, I'm starting to think we possibly shouldn't have them in the main library at all.

@iampluque
Copy link
Author

vacation for a week starting Friday

you are forgiven 😆

@jskeet jskeet self-assigned this Aug 17, 2022
@jskeet jskeet added the enhancement New feature or request label Aug 17, 2022
@jskeet
Copy link
Contributor

jskeet commented Aug 17, 2022

Hmm. This comment in the issue is interesting:

This extension will be kept as the OpenTelemetry WG for Messaging Sementics is interested in using and potentially updating it to aligned with the outcome of their work

The "potentially updating it" suggests it's not stable right now - which is in-keeping with the status as "extension" rather than "specification-defined attribute".

I've raised #232 for a potential plan. If we go ahead with that, we would want to just create a distributed tracing extensions as a new package rather than including it in the main package then making it obsolete. Thoughts welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants