-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency MQTTnet out of date and has breaking changes. #269
Comments
Thanks - we'll need to have a think about what to do here. We'd need a new major version (at least for the MQTT package) if we just bump the dependency - and at that point, anyone still using v3 would have problems. I wonder whether the right approach is to create a new package, CloudNative.CloudEvents.Mqtt4. What do you think? |
On a personal level I get annoyed with versioning in the package/namespace name. I understand why people sometimes do it though. |
So what would your proposal be as an alternative? How would you suggest we support v3 users and v4 users? Or just not support v3 users any more? |
Take the breaking change, drop v3 support (which hasn't been updated in > 18 mos). |
Right. And presumably release this as a new major version of just the MQTT CE package. (We don't want to disrupt other users, but we do want to signal the breaking change to MQTT users.) This is something I've thought we'll probably end up needing for a while - this is just the forcing function. I think "release everything all at the same time" is probably still appropriate, and we can keep a common minor/patch version, but vary major version by package... |
The dependency for MQTTnet is now at version 4.3.1.873, which includes some breaking changes (or at least some binary incompatibilities).
Attempting a project like so:
... ends up yielding
The text was updated successfully, but these errors were encountered: