Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review HTTP tests carefully #89

Open
jskeet opened this issue Feb 4, 2021 · 1 comment
Open

Review HTTP tests carefully #89

jskeet opened this issue Feb 4, 2021 · 1 comment
Assignees
@jskeet

Comments

@jskeet
Copy link
Contributor

jskeet commented Feb 4, 2021

Currently our ASP.NET Core integration test only works because when you create an HttpContent from an event without data, in binary mode, the formatter ends up creating content of "null" (as four bytes). If there's no data, we shouldn't be specifying a DataContentType or populating the request body - but that throws at the moment.

Likewise other HTTP tests specify a content type of XML despite using a JSON event formatter - it's not clear what the expected behaviour is there, in general. (That's related to #55.)
@jskeet jskeet self-assigned this Feb 4, 2021
@jskeet
Copy link
Contributor Author

jskeet commented Apr 12, 2021

The tests are a bit more sensible now, but they're not nearly comprehensive enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jskeet