Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Expose pubsub PublishSettings along with ReceiveSettings #1026

Open
JamesBLewis opened this issue Mar 16, 2024 · 0 comments · May be fixed by #1027
Open

Feature: Expose pubsub PublishSettings along with ReceiveSettings #1026

JamesBLewis opened this issue Mar 16, 2024 · 0 comments · May be fixed by #1027

Comments

@JamesBLewis
Copy link

JamesBLewis commented Mar 16, 2024 •
edited

Motivation

The google pubsub client allows you to configure your receive and publish settings. via pubsub.ReceiveSettings and pubsub.PublishSettings. This sdk exposes the ReceiveSettings in its interface via the protocol Struct but does not give the same treatment to PublishSettings. I propose we correct this omission with a backwards compatible change exposing this and thus allowing the user to configure things like batch publishing of messages without effecting the existing behaviour of the client.

As PublishSettings are not currently configurable, all events are published with pubsub.DefaultPublishSettings. This means that even by exposing ReceiveSettings we would not impact any programs which rely upon not specifying PublishSettings.
@JamesBLewis JamesBLewis changed the title Expose PublishSettings like already done for ReceiveSettings Feature: Expose PublishSettings along with ReceiveSettings Mar 16, 2024
@JamesBLewis JamesBLewis changed the title Feature: Expose PublishSettings along with ReceiveSettings Feature: Expose pubsub PublishSettings along with ReceiveSettings Mar 16, 2024
JamesBLewis added a commit to JamesBLewis/sdk-go that referenced this issue Mar 16, 2024
@JamesBLewis
Merge branch 'main' into cloudeventsgh-1026-expose-publishSettings
da1dff4
JamesBLewis added a commit to JamesBLewis/sdk-go that referenced this issue Mar 16, 2024
@JamesBLewis
Merge branch 'main' into cloudeventsgh-1026-expose-publishSettings
0142a6d
@JamesBLewis JamesBLewis linked a pull request Mar 16, 2024 that will close this issue
Open
JamesBLewis added a commit to JamesBLewis/sdk-go that referenced this issue Apr 4, 2024
@JamesBLewis
Merge branch 'main' into cloudeventsgh-1026-expose-publishSettings
855972e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for publishSettings JamesBLewis/sdk-go
1 participant
@JamesBLewis