Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why upgrade go.uber.org/atomic to version v1.10.0? #895

Open
xzygis opened this issue May 11, 2023 · 4 comments
Open

Why upgrade go.uber.org/atomic to version v1.10.0? #895

xzygis opened this issue May 11, 2023 · 4 comments

Comments

@xzygis
Copy link

xzygis commented May 11, 2023

Since I updated github.com/cloudevents/sdk-go/v2 to version v2.14.0, I found it depend on go.uber.org/atomic to version, and When I compile my code, the following error occurs:

# go.uber.org/multierr
../../../../pkg/mod/go.uber.org/multierr@v1.11.0/error.go:209:20: undefined: atomic.Bool
note: module requires Go 1.19

Did you really need to upgrade go.uber.org/atomic to version v1.10.0?

@duglin
Copy link
Contributor

duglin commented Jun 1, 2023

@lionelvillard @embano1 any thoughts on this one?

@xzygis at some point we'll need to update things. Atomic is already at v1.11.0 - what are you suggesting w.r.t. how long we wait before we upgrade packages?

@embano1
Copy link
Member

embano1 commented Jun 1, 2023

Checking...where is the v1.10.0 on go.uber.org/atomic? In v2 I see we're on v1.4.0 https://github.com/cloudevents/sdk-go/blob/main/v2/go.mod#L24

@duglin
Copy link
Contributor

duglin commented Jun 1, 2023

hmm @xzygis where do you see it?

@mike22664
Copy link

Duplicate of #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants