Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-compose to run integration tests easily locally #966

Open
3 tasks
embano1 opened this issue Oct 23, 2023 · 4 comments
Open
3 tasks

Create docker-compose to run integration tests easily locally #966

embano1 opened this issue Oct 23, 2023 · 4 comments
Assignees

Comments

@embano1
Copy link
Member

embano1 commented Oct 23, 2023

Acceptance criteria:

  • Docker compose file w/ hardcoded image versions (SHA)
  • Github actions to use the same file
  • Documentation

Ref: #963

@embano1 embano1 self-assigned this Oct 23, 2023
@duglin
Copy link
Contributor

duglin commented Oct 23, 2023

In general I'm ok with this, but it does raise the bar of what's required of devs. Personally, I don't use (or have installed compose) I if needed I can adapt :-)

@embano1
Copy link
Member Author

embano1 commented Oct 23, 2023

Compose comes with Docker (which we require already today). Based on my experience, it actually simplifies the developer experience and prevents common issues in multi-container setups.

@duglin
Copy link
Contributor

duglin commented Oct 23, 2023

oh cool - for some reason I thought it was a separate install.

@embano1
Copy link
Member Author

embano1 commented Oct 23, 2023

Yup, assuming most users have Docker Desktop installed

Compose V2 is included with all currently supported versions of Docker Desktop. For more information, see Migrate to Compose V2.

Compose V2 integrates compose functions into the Docker platform, continuing to support most of the previous docker-compose features and flags. You can run Compose V2 by replacing the hyphen (-) with a space, using docker compose, instead of docker-compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants