Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add full Java module descriptors #574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add full Java module descriptors #574

wants to merge 1 commit into from

Conversation

aalmiray
Copy link

Fixes #555

The following modules have been left as automatic

  • restful-ws
  • spring
  • rocketmq

Because of the following issues:

Execution add-module-infos of goal org.moditect:moditect-maven-plugin:1.0.0.Final:add-module-info failed: Module java.xml.bind not found, required by java.ws.rs

Error: Module rocketmq.client.java contains package javax.annotation, module annotations.api exports package javax.annotation to rocketmq.client.java

Error: Modules java.annotation and jsr305 export package javax.annotation to module spring.webmvc

@aalmiray
Add full Java module descriptors
e532206 
Closes cloudevents#555

Signed-off-by: Andres Almiray <aalmiray@gmail.com>
@aalmiray
Copy link
Author

aalmiray commented Feb 13, 2024 •
edited

ModiTect requires Java9+ to run. The build has been configured to keep producing Java 8 bytecode.
Build workflows can no longer be tested with Java 8. Added Java 21 as additional test target.

@aalmiray aalmiray mentioned this pull request Feb 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support full Java Module descriptors
1 participant
@aalmiray