Modified content-type to abide by attribute naming conventions for cloudevents #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @vivjd, thx for opening the PR. Unfortunately your change is not really what the desired behavior should be. I've mentioned the desired one here: #211 (comment) So if you're up for changing this to comply with the desired behavior I'd be glad to review the PR. |
|
Hi @xSAVIKx! Thank you for you feedback. I've reread the original issue and the desired behavior, and changed it accordingly in my PR. If you could review the PR that would be great! Thank you for your time! |
|
Hi @xSAVIKx, I changed the test cases to match the change. Could you please kindly review this again? Thank you in advance! |
xSAVIKx
approved these changes
Apr 3, 2024
Signed-off-by: vivjd <vivjdeng@hotmail.com>
Signed-off-by: Vivian <118199397+vivjd@users.noreply.github.com> Signed-off-by: vivjd <vivjdeng@hotmail.com>
Signed-off-by: vivjd <vivjdeng@hotmail.com>
…tributes Signed-off-by: vivjd <vivjdeng@hotmail.com>
|
Sorry, my bad. I was pretty sure I did that when I was reviewing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Changes
The
content-typeattribute will violate the attribute naming rules, so the attribute has been modified todatacontenttype.One line description for the changelog
Converted
content-typetodatacontenttypeforcloudevents.