Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event does not have new method #207

Open
xiaoas opened this issue Mar 8, 2023 · 0 comments
Open

Event does not have new method #207

xiaoas opened this issue Mar 8, 2023 · 0 comments

Comments

@xiaoas
Copy link
Contributor

xiaoas commented Mar 8, 2023 •
edited

Users expect to use Event::new() to construct a event.
According to API guideline: https://rust-lang.github.io/api-guidelines/predictability.html

  • we should implement Event::new()
  • we should revise the doc to encourage the use of Event::new()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xiaoas