Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DEX Tests #1209

Merged
merged 2 commits into from Feb 16, 2023
Merged

Support for DEX Tests #1209

merged 2 commits into from Feb 16, 2023

Conversation

dhens
Copy link
Contributor

@dhens dhens commented Feb 14, 2023

Add CRUD support for configuring Digital Experience Monitoring tests with terraform.

Has your change been tested?

Unit tests have been created to cover each endpoint and request methods.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #1209 (9b2e289) into master (c07adfc) will decrease coverage by 0.14%.
The diff coverage is 32.46%.

@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   49.36%   49.22%   -0.14%     
==========================================
  Files         128      129       +1     
  Lines       12430    12499      +69     
==========================================
+ Hits         6136     6153      +17     
- Misses       4890     4930      +40     
- Partials     1404     1416      +12     
Impacted Files Coverage Δ
dns.go 72.72% <ø> (ø)
devices_dex.go 32.46% <32.46%> (ø)
cloudflare.go 67.28% <0.00%> (-0.80%) ⬇️
devices_policy.go 49.47% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dhens dhens force-pushed the master branch 2 times, most recently from ee75986 to 159f2a0 Compare February 14, 2023 23:34
devices_dex.go Outdated Show resolved Hide resolved
devices_dex.go Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

couple of tiny nitpicks, otherwise 👍

@jacobbednarz
Copy link
Member

thanks @dhens!

@github-actions github-actions bot added this to the v0.62.0 milestone Feb 16, 2023
github-actions bot pushed a commit that referenced this pull request Feb 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

This functionality has been released in v0.62.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants