Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing: add support for Address Map resource #1232

Merged
merged 8 commits into from Mar 13, 2023
Merged

addressing: add support for Address Map resource #1232

merged 8 commits into from Mar 13, 2023

Conversation

hunts
Copy link
Contributor

@hunts hunts commented Mar 9, 2023

Description

This pull request adds support for the public Address Map apis.

About Address Map: https://developers.cloudflare.com/byoip/proxy-ips/
The API docs: https://api.cloudflare.com/#ip-address-management-address-maps-properties

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@hunts hunts requested a review from jacobbednarz as a code owner March 9, 2023 22:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

changelog detected ✅

addressing_address_map.go Outdated Show resolved Hide resolved
addressing_address_map.go Outdated Show resolved Hide resolved
addressing_address_map.go Outdated Show resolved Hide resolved
@hunts
Copy link
Contributor Author

hunts commented Mar 10, 2023

The Coverage action seems to be broken. @jacobbednarz . Is it a known issue?

@jacobbednarz
Copy link
Member

I'll have to have a look into it as to where the comparison is happening but that's fine to ignore it for now.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #1232 (dfb4848) into master (9ac4a16) will decrease coverage by 0.07%.
The diff coverage is 41.81%.

@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
- Coverage   49.31%   49.24%   -0.07%     
==========================================
  Files         130      131       +1     
  Lines       12557    12667     +110     
==========================================
+ Hits         6192     6238      +46     
- Misses       4940     4988      +48     
- Partials     1425     1441      +16     
Impacted Files Coverage Δ
addressing_ip_prefix.go 45.45% <ø> (ø)
convert_types.go 2.01% <ø> (ø)
addressing_address_map.go 39.04% <39.04%> (ø)
resource.go 83.33% <100.00%> (+4.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 3a67d01 into cloudflare:master Mar 13, 2023
@jacobbednarz
Copy link
Member

thanks for this one @hunts 🍰

@github-actions github-actions bot added this to the v0.63.0 milestone Mar 13, 2023
github-actions bot pushed a commit that referenced this pull request Mar 13, 2023
@hunts hunts deleted the hunts/add-support-for-address-maps-apis branch March 13, 2023 17:52
@hunts
Copy link
Contributor Author

hunts commented Mar 13, 2023

Awesome! Thanks for the help @jacobbednarz on releasing this feature.

@github-actions
Copy link
Contributor

This functionality has been released in v0.63.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@cloudflare cloudflare locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants