Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CreateTunnel for tunnels with config_src #1238

Merged
merged 2 commits into from Mar 22, 2023

Conversation

janpuc
Copy link
Contributor

@janpuc janpuc commented Mar 21, 2023

Description

CreateTunnel previously did not use config_src in the request. Removed unnecessary reference to Tunnel object and passed params for tunnel creation directly to the URI.

Has your change been tested?

Yes. Ran all automated tests and none of them have been broken. Also test in tunnel_test.go already covered new tunnel creation with expected config_src.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

CreateTunnel previously did not use config_src in the request
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

changelog detected ✅

@janpuc janpuc changed the title Fix CreateTunnel Fix CreateTunnel for tunnels with config_src Mar 21, 2023
@jacobbednarz jacobbednarz merged commit 35a1d3e into cloudflare:master Mar 22, 2023
11 checks passed
@jacobbednarz
Copy link
Member

thanks @janpuc, appreciate it!

@github-actions github-actions bot added this to the v0.64.0 milestone Mar 22, 2023
github-actions bot pushed a commit that referenced this pull request Mar 22, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.64.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants