Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Create/UpdateDNSRecord method signatures #1243

Merged

Conversation

joaoafonsopereira
Copy link
Contributor

Disclaimer: this is my first ever contribution to an open-source project, so any suggestions that help me improve my PR game are very welcome.

Description

Changes CreateDNSRecord and UpdateDNSRecord method signatures such that they both return (DNSRecord, error).
Closes #1239

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1243 (c283e37) into master (9ac4a16) will decrease coverage by 0.08%.
The diff coverage is 45.16%.

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage   49.31%   49.23%   -0.08%     
==========================================
  Files         130      131       +1     
  Lines       12557    12665     +108     
==========================================
+ Hits         6192     6236      +44     
- Misses       4940     4988      +48     
- Partials     1425     1441      +16     
Impacted Files Coverage Δ
access_identity_provider.go 70.00% <ø> (ø)
addressing_ip_prefix.go 45.45% <ø> (ø)
convert_types.go 2.01% <ø> (ø)
addressing_address_map.go 39.04% <39.04%> (ø)
dns.go 73.21% <69.23%> (ø)
resource.go 83.33% <100.00%> (+4.38%) ⬆️
tunnel.go 41.39% <100.00%> (-0.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz
Copy link
Member

jacobbednarz commented Mar 24, 2023

this is my first ever contribution to an open-source project, so any suggestions that help me improve my PR game are very welcome.

congrats! this is a super solid first PR 🏆

  • you opened an issue to discuss the proposed changes ✅
  • you read the contribution guidelines ✅
  • you filled out the PR template with the context of the change and the requirements ✅
  • you updated associated tests ✅
  • you added a CHANGELOG entry ✅
  • you used GitHub closing keywords to link issues ✅

no comments from me other than i wish more contributions were like this since it is on point. thank you!

hopefully this is the first of many PRs to come!

@jacobbednarz jacobbednarz merged commit 25c8d5b into cloudflare:master Mar 24, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.64.0 milestone Mar 24, 2023
github-actions bot pushed a commit that referenced this pull request Mar 24, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.64.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change UpdateDNSRecord to also return the DNSRecordResponse
3 participants