Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Turnstile #1267

Merged
merged 15 commits into from Apr 18, 2023
Merged

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Apr 14, 2023

Description

Adds support for turnstile widgets

Has your change been tested?

New tests added

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@gitguardian
Copy link

gitguardian bot commented Apr 14, 2023

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 0ed2611 challenge_widgets_test.go View secret
- Generic High Entropy Secret 0ed2611 challenge_widgets_test.go View secret
- Generic High Entropy Secret 0ed2611 challenge_widgets_test.go View secret
- Generic High Entropy Secret 0ed2611 challenge_widgets_test.go View secret
- Generic High Entropy Secret 0ed2611 challenge_widgets_test.go View secret
- Generic High Entropy Secret 0ed2611 challenge_widgets_test.go View secret
- Generic High Entropy Secret 0ed2611 challenge_widgets_test.go View secret
- Generic High Entropy Secret 3421d5d challenge_widgets_test.go View secret
- Generic High Entropy Secret 3421d5d challenge_widgets_test.go View secret
- Generic High Entropy Secret cf6ed3d turnstile_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions
Copy link
Contributor

changelog detected ✅

@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as draft April 15, 2023 20:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Merging #1267 (fb44b2d) into master (0c3db86) will decrease coverage by 0.03%.
The diff coverage is 43.24%.

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   49.23%   49.21%   -0.03%     
==========================================
  Files         131      132       +1     
  Lines       12665    12879     +214     
==========================================
+ Hits         6236     6338     +102     
- Misses       4988     5079      +91     
- Partials     1441     1462      +21     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
access_policy.go 76.31% <ø> (ø)
cloudflare.go 67.28% <ø> (ø)
dns.go 45.05% <0.00%> (-28.16%) ⬇️
errors.go 40.78% <ø> (ø)
rulesets.go 34.64% <0.00%> (-0.35%) ⬇️
ssl.go 72.72% <ø> (ø)
zone.go 41.70% <50.00%> (+2.59%) ⬆️
turnstile.go 67.76% <67.76%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as ready for review April 17, 2023 21:44
turnstile.go Outdated Show resolved Hide resolved
turnstile.go Outdated Show resolved Hide resolved
turnstile.go Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

@punkeel are you 👌 to this one being merged?

@worenga
Copy link

worenga commented Apr 18, 2023

lgtm!

@jacobbednarz jacobbednarz merged commit 0901795 into cloudflare:master Apr 18, 2023
10 of 11 checks passed
@github-actions github-actions bot added this to the v0.66.0 milestone Apr 18, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the turnstile branch April 19, 2023 00:08
@github-actions
Copy link
Contributor

This functionality has been released in v0.66.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants