Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing posture check providers #1268

Merged
merged 2 commits into from May 2, 2023

Conversation

suhrit-cf
Copy link
Contributor

@suhrit-cf suhrit-cf commented Apr 17, 2023

  • Intune
  • Tanium
  • Kolide

We are missing these three posture checks so that we can use it in terraform provider repo.

Description

Users cannot use terraform to add posture checks of these three type even when they are supported via dash. So we need to provide this functionality via terraform.

Has your change been tested?

Yes

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

i see tanium at https://developers.cloudflare.com/api/operations/device-posture-rules-device-posture-rules-details but not the others. parking this one pending some API doc updates.

@codecov-commenter
Copy link

Codecov Report

Merging #1268 (17b7591) into master (0c3db86) will decrease coverage by 0.21%.
The diff coverage is 13.86%.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   49.23%   49.03%   -0.21%     
==========================================
  Files         131      131              
  Lines       12665    12758      +93     
==========================================
+ Hits         6236     6256      +20     
- Misses       4988     5053      +65     
- Partials     1441     1449       +8     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
access_policy.go 76.31% <ø> (ø)
device_posture_rule.go 61.80% <ø> (ø)
dns.go 45.05% <0.00%> (-28.16%) ⬇️
errors.go 40.78% <ø> (ø)
rulesets.go 34.64% <0.00%> (-0.35%) ⬇️
ssl.go 72.72% <ø> (ø)
zone.go 41.70% <50.00%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@suhrit-cf
Copy link
Contributor Author

Documents have been updated.

@jacobbednarz jacobbednarz merged commit 59bbea3 into cloudflare:master May 2, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.67.0 milestone May 2, 2023
github-actions bot pushed a commit that referenced this pull request May 2, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.67.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants