Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA-2043 - Add support for regional hostnames #1270

Conversation

aberglund-cf
Copy link
Contributor

Description

Adds methods which covers the Regional Hostname API calls documented here: https://developers.cloudflare.com/data-localization/regional-services/get-started/

Has your change been tested?

  • Unit tests
  • Manual testing in staging environment

Types of changes

What sort of change does your code introduce/modify?

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #1270 (b59070a) into master (0c3db86) will decrease coverage by 0.11%.
The diff coverage is 42.13%.

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   49.23%   49.13%   -0.11%     
==========================================
  Files         131      133       +2     
  Lines       12665    12994     +329     
==========================================
+ Hits         6236     6384     +148     
- Misses       4988     5125     +137     
- Partials     1441     1485      +44     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_organization.go 64.70% <ø> (ø)
access_policy.go 76.31% <ø> (ø)
cloudflare.go 67.28% <ø> (ø)
dns.go 45.05% <0.00%> (-28.16%) ⬇️
errors.go 40.78% <ø> (ø)
rulesets.go 34.64% <0.00%> (-0.35%) ⬇️
ssl.go 72.72% <ø> (ø)
regional_hostnames.go 40.00% <40.00%> (ø)
zone.go 41.70% <50.00%> (+2.59%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gitguardian
Copy link

gitguardian bot commented Apr 19, 2023

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 5d81262 turnstile_test.go View secret
- Generic High Entropy Secret 5d81262 turnstile_test.go View secret
- Generic High Entropy Secret 5d81262 turnstile_test.go View secret
- Generic High Entropy Secret 5d81262 turnstile_test.go View secret
- Generic High Entropy Secret 5d81262 turnstile_test.go View secret
- Generic High Entropy Secret 5d81262 turnstile_test.go View secret
- Generic High Entropy Secret 5d81262 turnstile_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Updates the methods to have dedicated third parameters which simplifies
the methods and will allow them to move independently.
@jacobbednarz jacobbednarz force-pushed the aberglund-cf/PA-2107-add_support_for_regional_hostnames branch from 9f7e095 to f9943be Compare April 19, 2023 02:51
@jacobbednarz jacobbednarz merged commit ac01413 into cloudflare:master Apr 19, 2023
10 of 11 checks passed
@github-actions github-actions bot added this to the v0.66.0 milestone Apr 19, 2023
@jacobbednarz
Copy link
Member

thanks @aberglund-cf! this is great 👏

github-actions bot pushed a commit that referenced this pull request Apr 19, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.66.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants