Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Logpush fields for max upload params #1272

Merged
merged 2 commits into from Apr 23, 2023

Conversation

Evesy
Copy link
Contributor

@Evesy Evesy commented Apr 21, 2023

Description

Adds new Logpush fields as documented here https://developers.cloudflare.com/logs/get-started/api-configuration/#max-upload-parameters

  • max_upload_bytes
  • max_upload_records
  • max_upload_interval_seconds

The new fields do have server side validation around the integer values, I wasn't sure whether this client should perform the same validation. Opted out for now as I assume the client doesn't want to be tied into values that could easily change in Cloudflares API.
Similarly, max_upload_bytes and max_upload_records cannot be used if kind is set to edge, not sure if that's validation that should be done in the client or not?

Has your change been tested?

Added to existing logpush tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@Evesy Evesy changed the title Add new fields for max upload params Add new Logpush fields for max upload params Apr 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1272 (1773aea) into master (0c3db86) will decrease coverage by 0.14%.
The diff coverage is 40.90%.

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   49.23%   49.10%   -0.14%     
==========================================
  Files         131      133       +2     
  Lines       12665    12987     +322     
==========================================
+ Hits         6236     6377     +141     
- Misses       4988     5125     +137     
- Partials     1441     1485      +44     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_organization.go 64.70% <ø> (ø)
access_policy.go 76.31% <ø> (ø)
cloudflare.go 67.28% <ø> (ø)
dns.go 45.05% <0.00%> (-28.16%) ⬇️
errors.go 40.78% <ø> (ø)
logpush.go 52.10% <ø> (ø)
rulesets.go 34.64% <0.00%> (-0.35%) ⬇️
ssl.go 72.72% <ø> (ø)
regional_hostnames.go 36.11% <36.11%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 4efe968 into cloudflare:master Apr 23, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.66.0 milestone Apr 23, 2023
github-actions bot pushed a commit that referenced this pull request Apr 23, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.66.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants