Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WR-1279 add waiting room zone-level settings #1276

Merged
merged 2 commits into from May 8, 2023

Conversation

piperswe
Copy link
Contributor

@piperswe piperswe commented May 4, 2023

Description

This adds support for the new Waiting Room zone-level settings, which are used to enable search engine crawler bypass.

Has your change been tested?

Tests were added, mirroring the other tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

changelog detected ✅

@piperswe piperswe force-pushed the piper/wr-1279 branch 2 times, most recently from 0c62837 to c8fac53 Compare May 4, 2023 21:12
@piperswe piperswe marked this pull request as ready for review May 5, 2023 00:32
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #1276 (3508050) into master (0c3db86) will decrease coverage by 0.17%.
The diff coverage is 40.58%.

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
- Coverage   49.23%   49.07%   -0.17%     
==========================================
  Files         131      133       +2     
  Lines       12665    13032     +367     
==========================================
+ Hits         6236     6395     +159     
- Misses       4988     5143     +155     
- Partials     1441     1494      +53     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_organization.go 64.70% <ø> (ø)
access_policy.go 76.31% <ø> (ø)
certificate_packs.go 50.90% <ø> (ø)
cloudflare.go 67.28% <ø> (ø)
device_posture_rule.go 61.80% <ø> (ø)
dns.go 45.05% <0.00%> (-28.16%) ⬇️
dns_firewall.go 21.42% <ø> (ø)
errors.go 40.78% <ø> (ø)
logpush.go 52.10% <ø> (ø)
... and 7 more

@jacobbednarz
Copy link
Member

thanks for the PR @piperswe 🙇 the changes themselves look fine (minor nitpicks inline) however, for the method signatures, i'd recommend swapping to the method signature conventions outlined in the experimental documentation which allows more flexibility but stronger type guarantees for the future. if you're looking for some prior art, you can checkout #1270 which was a new resource added within the last couple of weeks that follows these conventions. i've also commented on one of the methods to help you get started.

waiting_room.go Outdated Show resolved Hide resolved
waiting_room.go Outdated Show resolved Hide resolved
waiting_room_test.go Outdated Show resolved Hide resolved
waiting_room.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 03d8ad1 into cloudflare:master May 8, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.67.0 milestone May 8, 2023
@jacobbednarz
Copy link
Member

github-actions bot pushed a commit that referenced this pull request May 8, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.67.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants