Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for cache reserve #1278

Merged
merged 4 commits into from May 15, 2023

Conversation

jfchevrette
Copy link
Contributor

Description

Add support for retrieving and updating the Cache Reserve setting on a zone

This is a rather naive implementation which follows the same pattern as the argo.go methods

Closes #1277

Has your change been tested?

Unit tests included

I also tested locally on a real account and I was able to retrieve and set the cache_reserve setting

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

changelog detected ✅

@jfchevrette jfchevrette force-pushed the zone-cache-reserve branch 2 times, most recently from a5193d1 to ffd506d Compare May 9, 2023 00:41
zone_cache_reserve.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #1278 (cf0ce93) into master (3508050) will decrease coverage by 0.02%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
- Coverage   49.07%   49.05%   -0.02%     
==========================================
  Files         133      134       +1     
  Lines       13032    13064      +32     
==========================================
+ Hits         6395     6409      +14     
- Misses       5143     5155      +12     
- Partials     1494     1500       +6     
Impacted Files Coverage Δ
rulesets.go 34.64% <ø> (ø)
cache_reserve.go 43.75% <43.75%> (ø)

zone_cache_reserve.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 3b8bf87 into cloudflare:master May 15, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.68.0 milestone May 15, 2023
github-actions bot pushed a commit that referenced this pull request May 15, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.68.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
@jfchevrette jfchevrette deleted the zone-cache-reserve branch August 1, 2023 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cache Reserve
4 participants