Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for self_hosted_domains in access applications #1281

Merged
merged 1 commit into from Jun 6, 2023

Conversation

GreenStage
Copy link
Contributor

@GreenStage GreenStage commented May 16, 2023

The ZT access team recently shipped support for multiple domains in self hosted apps.
The array self_hosted_domains defined the set of domains that access will match this app for.

Has your change been tested?

unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1281 (5a56eb7) into master (3508050) will decrease coverage by 0.02%.
The diff coverage is 43.75%.

❗ Current head 5a56eb7 differs from pull request most recent head 3c395c3. Consider uploading reports for the commit 3c395c3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1281      +/-   ##
==========================================
- Coverage   49.07%   49.05%   -0.02%     
==========================================
  Files         133      134       +1     
  Lines       13032    13064      +32     
==========================================
+ Hits         6395     6409      +14     
- Misses       5143     5155      +12     
- Partials     1494     1500       +6     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
rulesets.go 34.64% <ø> (ø)
cache_reserve.go 43.75% <43.75%> (ø)

@jroyal
Copy link
Contributor

jroyal commented Jun 6, 2023

This is now in the public documentation https://developers.cloudflare.com/api/operations/access-applications-add-an-application. Can we get this merged if we are happy with it?

@jacobbednarz
Copy link
Member

certainly! thanks for the follow up.

@jacobbednarz jacobbednarz merged commit 81c4fb1 into cloudflare:master Jun 6, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.69.0 milestone Jun 6, 2023
github-actions bot pushed a commit that referenced this pull request Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This functionality has been released in v0.69.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants