Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UpdateTurnstileWidget #1284

Merged

Conversation

punkeel
Copy link
Member

@punkeel punkeel commented May 17, 2023

Description

The request body must not include sitekey/secret, but did. This fixes it.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

.changelog/1284.txt Outdated Show resolved Hide resolved
@punkeel punkeel force-pushed the maxime/fix-UpdateTurnstileWidget branch from d555d68 to 4d7698c Compare May 17, 2023 02:51
The request body must not include sitekey/secret, but did.
This fixes it.
@punkeel punkeel force-pushed the maxime/fix-UpdateTurnstileWidget branch from 4d7698c to 41984cb Compare May 17, 2023 02:52
@codecov-commenter
Copy link

Codecov Report

Merging #1284 (d555d68) into master (3508050) will decrease coverage by 0.01%.
The diff coverage is 48.57%.

❗ Current head d555d68 differs from pull request most recent head 41984cb. Consider uploading reports for the commit 41984cb to get more accurate results

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
- Coverage   49.07%   49.06%   -0.01%     
==========================================
  Files         133      134       +1     
  Lines       13032    13066      +34     
==========================================
+ Hits         6395     6411      +16     
- Misses       5143     5155      +12     
- Partials     1494     1500       +6     
Impacted Files Coverage Δ
pages_project.go 50.81% <ø> (ø)
rulesets.go 34.64% <ø> (ø)
turnstile.go 67.76% <ø> (ø)
cache_reserve.go 43.75% <43.75%> (ø)
workers.go 59.01% <100.00%> (+0.45%) ⬆️

.changelog/1284.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit a73c78b into cloudflare:master May 17, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request May 17, 2023
@github-actions github-actions bot added this to the v0.68.0 milestone May 17, 2023
@punkeel punkeel mentioned this pull request May 17, 2023
9 tasks
@github-actions
Copy link
Contributor

This functionality has been released in v0.68.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@punkeel punkeel deleted the maxime/fix-UpdateTurnstileWidget branch May 23, 2023 23:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants