Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RotateTurnstileWidget #1285

Merged
merged 1 commit into from May 17, 2023
Merged

Conversation

punkeel
Copy link
Member

@punkeel punkeel commented May 17, 2023

Description

Don't send the Sitekey in the request body.
Server-side API will reject the request if it contains the sitekey (because it belongs in the URL)

Similar to #1284, but for the other method. Promise the other 2 functions don't need a similar fix

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

Don't send the Sitekey in the request body.
@github-actions
Copy link
Contributor

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 7d72dcb into cloudflare:master May 17, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.68.0 milestone May 17, 2023
github-actions bot pushed a commit that referenced this pull request May 17, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.68.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@punkeel punkeel deleted the maxime/1285 branch May 23, 2023 23:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants