Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW-5588: Add hostname and ASN lists #1288

Merged
merged 1 commit into from May 23, 2023

Conversation

obbap1
Copy link

@obbap1 obbap1 commented May 22, 2023

Description

This adds support for Hostname and ASN lists

Has your change been tested?

Integration tests were written to ensure the requests are parsed successfully.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@obbap1 obbap1 requested a review from jacobbednarz as a code owner May 22, 2023 20:06
@github-actions
Copy link
Contributor

changelog detected ✅

@obbap1 obbap1 marked this pull request as draft May 22, 2023 20:19
@obbap1 obbap1 marked this pull request as ready for review May 22, 2023 20:37
@codecov-commenter
Copy link

Codecov Report

Merging #1288 (656b03b) into master (62eaa9a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1288   +/-   ##
=======================================
  Coverage   49.06%   49.07%           
=======================================
  Files         134      134           
  Lines       13066    13066           
=======================================
+ Hits         6411     6412    +1     
+ Misses       5155     5154    -1     
  Partials     1500     1500           
Impacted Files Coverage Δ
list.go 25.00% <ø> (ø)

... and 1 file with indirect coverage changes

@jacobbednarz jacobbednarz merged commit 9096b96 into cloudflare:master May 23, 2023
13 checks passed
@github-actions github-actions bot added this to the v0.68.0 milestone May 23, 2023
github-actions bot pushed a commit that referenced this pull request May 23, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.68.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants