Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flarectl/dns: dereference priority pointer #1289

Merged

Conversation

jacobbednarz
Copy link
Member

Closes #1282

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

changelog detected ✅

@jacobbednarz jacobbednarz force-pushed the ensure-dns-priority-is-derefed branch from a5dc232 to b9c7a0e Compare May 23, 2023 05:35
@codecov-commenter
Copy link

Codecov Report

Merging #1289 (a5dc232) into master (62eaa9a) will increase coverage by 0.01%.
The diff coverage is 61.29%.

❗ Current head a5dc232 differs from pull request most recent head b9c7a0e. Consider uploading reports for the commit b9c7a0e to get more accurate results

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
+ Coverage   49.06%   49.07%   +0.01%     
==========================================
  Files         134      134              
  Lines       13066    13091      +25     
==========================================
+ Hits         6411     6425      +14     
- Misses       5155     5162       +7     
- Partials     1500     1504       +4     
Impacted Files Coverage Δ
list.go 25.00% <ø> (ø)
r2_bucket.go 66.12% <61.29%> (-9.55%) ⬇️

... and 1 file with indirect coverage changes

@jacobbednarz jacobbednarz merged commit a49c7a6 into cloudflare:master May 23, 2023
11 checks passed
@jacobbednarz jacobbednarz deleted the ensure-dns-priority-is-derefed branch May 23, 2023 05:37
@github-actions github-actions bot added this to the v0.68.0 milestone May 23, 2023
github-actions bot pushed a commit that referenced this pull request May 23, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.68.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MX priority not read/set correctly
2 participants