Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account level custom nameservers #1304

Merged
merged 9 commits into from Jun 14, 2023

Conversation

rwhelan
Copy link
Contributor

@rwhelan rwhelan commented Jun 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1304 (68b50a2) into master (5584c5b) will decrease coverage by 0.04%.
The diff coverage is 42.66%.

@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
- Coverage   49.07%   49.03%   -0.04%     
==========================================
  Files         134      135       +1     
  Lines       13090    13165      +75     
==========================================
+ Hits         6424     6456      +32     
- Misses       5162     5197      +35     
- Partials     1504     1512       +8     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
load_balancing.go 59.40% <ø> (ø)
stream.go 64.91% <ø> (ø)
account_level_custom_nameservers.go 42.66% <42.66%> (ø)

@jacobbednarz jacobbednarz merged commit d811f5f into cloudflare:master Jun 14, 2023
11 checks passed
@jacobbednarz
Copy link
Member

thanks for the PR here @rwhelan 👋

@github-actions github-actions bot added this to the v0.70.0 milestone Jun 14, 2023
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.70.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Account Level Custom Nameservers
3 participants