Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie_suffix and additional_routes fields to Waiting Room object #1311

Merged
merged 3 commits into from Jun 16, 2023

Conversation

yj7o5
Copy link
Contributor

@yj7o5 yj7o5 commented Jun 15, 2023

This PR adds the 2 new fields that has been added to the Waiting Room object, namely, additional_routes and cookie_suffix to support the functionality of multihost and multipath feature.

https://developers.cloudflare.com/api/operations/waiting-room-create-waiting-room#request-body

Description

The documentation has been updated however the client needs a sync and therefore the terraform changes.

Has your change been tested?

Yes, Waiting Room relevant tests have been updated to handle the addition of these 2 new fields.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@yj7o5 yj7o5 requested a review from jacobbednarz as a code owner June 15, 2023 14:31
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

changelog detected ✅

.changelog/1311.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1311 (9b624a0) into master (5584c5b) will decrease coverage by 0.13%.
The diff coverage is 31.11%.

❗ Current head 9b624a0 differs from pull request most recent head 74e0b34. Consider uploading reports for the commit 74e0b34 to get more accurate results

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   49.07%   48.95%   -0.13%     
==========================================
  Files         134      135       +1     
  Lines       13090    13180      +90     
==========================================
+ Hits         6424     6452      +28     
- Misses       5162     5212      +50     
- Partials     1504     1516      +12     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
load_balancing.go 59.40% <ø> (ø)
stream.go 64.91% <ø> (ø)
waiting_room.go 45.72% <ø> (ø)
custom_nameservers.go 31.11% <31.11%> (ø)

@jacobbednarz jacobbednarz merged commit 907e506 into cloudflare:master Jun 16, 2023
10 checks passed
@jacobbednarz
Copy link
Member

thank you @yj7o5 👏 this is awesome 🙇

@github-actions github-actions bot added this to the v0.70.0 milestone Jun 16, 2023
github-actions bot pushed a commit that referenced this pull request Jun 16, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.70.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants