Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare: remove all references to api.AccountID #1315

Merged

Conversation

jacobbednarz
Copy link
Member

Now that all references to api.AccountID are removed, we can pull out the
helpers that were setting it along with any other method references.

Closes #1154

@jacobbednarz jacobbednarz changed the title cloudflare: remove all references to api.AccountID cloudflare: remove all references to api.AccountID Jun 19, 2023
@github-actions
Copy link
Contributor

changelog detected ✅

Now that all references to `api.AccountID` are removed, we can pull out the
helpers that were setting it along with any other method references.
@codecov-commenter
Copy link

Codecov Report

Merging #1315 (3dc24ce) into master (74e0b34) will decrease coverage by 0.21%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   48.95%   48.75%   -0.21%     
==========================================
  Files         135      133       -2     
  Lines       13180    12978     -202     
==========================================
- Hits         6452     6327     -125     
+ Misses       5212     5146      -66     
+ Partials     1516     1505      -11     
Impacted Files Coverage Δ
options.go 61.01% <ø> (-3.05%) ⬇️
dns_firewall.go 7.69% <10.00%> (-13.74%) ⬇️
cloudflare.go 66.77% <100.00%> (-0.52%) ⬇️
resource.go 85.18% <100.00%> (+1.85%) ⬆️

... and 1 file with indirect coverage changes

@jacobbednarz jacobbednarz merged commit 3745b3f into cloudflare:master Jun 19, 2023
11 checks passed
@jacobbednarz jacobbednarz deleted the no-more-account-global-state branch June 19, 2023 23:31
@github-actions github-actions bot added this to the v0.70.0 milestone Jun 19, 2023
github-actions bot pushed a commit that referenced this pull request Jun 19, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.70.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete removal of the global api.AccountID
2 participants