Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OS Version Extra in posture rule creation #1316

Merged
merged 3 commits into from Jun 22, 2023

Conversation

suhrit-cf
Copy link
Contributor

@suhrit-cf suhrit-cf commented Jun 22, 2023

Description

We want to give our users ability to enter os_version_extra while creating posture rule. This directly maps to product version extra that mac os uses in some instances for versioning.

Has your change been tested?

Yes

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

changelog detected ✅

device_posture_rule.go Outdated Show resolved Hide resolved
teams_devices_test.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit c44bea8 into cloudflare:master Jun 22, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.71.0 milestone Jun 22, 2023
github-actions bot pushed a commit that referenced this pull request Jun 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

This functionality has been released in v0.71.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants