Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert access application #1319

Merged
merged 23 commits into from Jun 26, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

Description

  • Converts Access Applications to the ResourceContainer to simplify usage
  • Adds support for auto pagination for Access Applications

Has your change been tested?

Existing test pass

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@Cyb3r-Jak3
Copy link
Contributor Author

This started with me wanting to add pagination, but here we are.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2023

changelog detected ✅

@Cyb3r-Jak3
Copy link
Contributor Author

The ListAccessIdentityProviders test is broken and still looking into why.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #1319 (1e579b5) into master (74e0b34) will decrease coverage by 0.60%.
The diff coverage is 73.36%.

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
- Coverage   48.95%   48.35%   -0.60%     
==========================================
  Files         135      133       -2     
  Lines       13180    12933     -247     
==========================================
- Hits         6452     6254     -198     
+ Misses       5212     5165      -47     
+ Partials     1516     1514       -2     
Impacted Files Coverage Δ
access_audit_log.go 79.31% <0.00%> (ø)
device_posture_rule.go 61.80% <ø> (ø)
options.go 61.01% <ø> (-3.05%) ⬇️
teams_devices.go 52.63% <ø> (ø)
dns_firewall.go 7.69% <10.00%> (-13.74%) ⬇️
tunnel.go 42.41% <66.66%> (+1.01%) ⬆️
access_policy.go 70.27% <73.33%> (-6.05%) ⬇️
access_application.go 72.72% <75.47%> (-3.80%) ⬇️
access_mutual_tls_certificates.go 68.86% <75.51%> (-3.36%) ⬇️
access_group.go 70.00% <76.00%> (-5.23%) ⬇️
... and 8 more

... and 1 file with indirect coverage changes

@jacobbednarz jacobbednarz merged commit e1c1342 into cloudflare:master Jun 26, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.71.0 milestone Jun 26, 2023
github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the access-application-paginate branch June 26, 2023 21:59
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

This functionality has been released in v0.71.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants