Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch namespace features #1330

Merged

Conversation

aaronlisman
Copy link
Contributor

Description

Adds support for several Workers for Platforms features:

  • dispatch namespace bindings
  • uploading workers 'to' a dispatch namespace

Also includes a few internal-ish items:

Has your change been tested?

Yes, besides pipeline_hash, but they've only been tested against the mock handlers in the included tests.

Types of changes

What sort of change does your code introduce/modify?

  • [❌ ] Bug fix (non-breaking change which fixes an issue)
  • [✅ ] New feature (non-breaking change which adds functionality)
  • [❌ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [✅] My code follows the code style of this project.
  • [❓] My change requires a change to the documentation.
    • Possibly. The public features are documented on developers.cloudflare.com, but I don't believe the library changes are.
  • [❌] I have updated the documentation accordingly.
  • [✅] I have added tests to cover my changes.
  • [✅] All new and existing tests passed.
  • [❓] This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.
    • The WFP APIs should be stable.
    • The 'unsafe' binding API is specifically to avoid adding support for some unstable features.
    • The pipeline_hash field is internal and unstable, but has been requested by some users.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

changelog detected ✅

workers_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1330 (0de7841) into master (b9ac804) will increase coverage by 0.24%.
The diff coverage is 64.37%.

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
+ Coverage   48.33%   48.58%   +0.24%     
==========================================
  Files         133      133              
  Lines       13023    13131     +108     
==========================================
+ Hits         6295     6380      +85     
- Misses       5201     5217      +16     
- Partials     1527     1534       +7     
Impacted Files Coverage Δ
logpush.go 51.81% <46.15%> (-0.30%) ⬇️
pages_deployment.go 38.88% <61.76%> (+4.64%) ⬆️
workers_bindings.go 67.90% <71.05%> (+0.46%) ⬆️
pages_project.go 58.22% <90.00%> (+7.40%) ⬆️
access_policy.go 70.27% <100.00%> (ø)
pagination.go 100.00% <100.00%> (+28.57%) ⬆️
workers.go 60.10% <100.00%> (+0.64%) ⬆️

@aaronlisman aaronlisman force-pushed the alisman/dispatch-namespace-features branch from 60451aa to a7e5e5e Compare July 12, 2023 18:38
- Fix lints
- Add changelog
- Document unsafe binding with example
- Change some asserts to requires in tests
@aaronlisman aaronlisman force-pushed the alisman/dispatch-namespace-features branch from a7e5e5e to d1c8036 Compare July 18, 2023 18:13
@jacobbednarz jacobbednarz merged commit f77c504 into cloudflare:master Jul 25, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.74.0 milestone Jul 25, 2023
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This functionality has been released in v0.74.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants