rulesets: modernise methods #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
Updates the ruleset methods to be in line with our experimental conventions. This change also makes it clearer the purpose of `GetRulesetEntrypoint` methods which were previously confusing to use.
jacobbednarz
force-pushed
the
modernise-ruleset
branch
from
fa19a0c
to
89cdca3
Compare
zakcutner
reviewed
Jul 12, 2023
Co-authored-by: Zak Cutner <me@zakcutner.com>
Co-authored-by: Zak Cutner <me@zakcutner.com>
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
+ Coverage 48.33% 48.43% +0.09%
==========================================
Files 133 133
Lines 13023 13067 +44
==========================================
+ Hits 6295 6329 +34
- Misses 5201 5206 +5
- Partials 1527 1532 +5
|
|
This functionality has been released in v0.73.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ruleset methods to be in line with our experimental conventions. This change also makes it clearer the purpose of
GetEntrypointRulesetmethods which were previously confusing to use.