New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Regional Tiered Cache API support #1336
Add Regional Tiered Cache API support #1336
Conversation
changelog detected ✅ |
type zoneRegionalTieredCacheSingleResponse struct { | ||
Response | ||
Result RegionalTieredCache `json:"result"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this separate struct is preferred (since the contents are the same)... saw this pattern introduced here: f047e55#diff-46ac00cf63f77e30464ff4ec022cc846b403a56c9e91b9b84f1de982aae6419cR30-R33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this seems 👌
thanks - i've confirmed internally this is just a byproduct of the rendering of the example. |
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
+ Coverage 48.33% 48.42% +0.08%
==========================================
Files 133 134 +1
Lines 13023 13104 +81
==========================================
+ Hits 6295 6345 +50
- Misses 5201 5220 +19
- Partials 1527 1539 +12
|
much appreciated @joshuamsager 👏 |
This functionality has been released in v0.73.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Closes #1334
Has your change been tested?
Tests added in:
regional_tiered_cache_test.go
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.