Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client_certificate and sentinelone_s2s posture rules #1339

Merged
merged 1 commit into from Jul 19, 2023

Conversation

jlu-cloudflare
Copy link
Contributor

Description

Added fields to DevicePostureRuleInput to accommodate needed inputs for the new posture types: client_certificate and sentinelone_s2s.

Has your change been tested?

Because it is just adding fields to the DevicePostureRuleInput struct, this should not affect existing uses of it. There has been a test created to test the creation of the client_certificate posture rule to test out the added fields.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1339 (1b543e5) into master (b9ac804) will increase coverage by 0.08%.
The diff coverage is 58.14%.

@@            Coverage Diff             @@
##           master    #1339      +/-   ##
==========================================
+ Coverage   48.33%   48.42%   +0.08%     
==========================================
  Files         133      134       +1     
  Lines       13023    13104      +81     
==========================================
+ Hits         6295     6345      +50     
- Misses       5201     5220      +19     
- Partials     1527     1539      +12     
Impacted Files Coverage Δ
device_posture_rule.go 61.80% <ø> (ø)
regional_tiered_cache.go 43.75% <43.75%> (ø)
logpush.go 51.81% <46.15%> (-0.30%) ⬇️
images.go 44.70% <47.82%> (-0.12%) ⬇️
rulesets.go 30.03% <52.17%> (-4.61%) ⬇️
pages_deployment.go 38.88% <61.76%> (+4.64%) ⬆️
pages_project.go 58.22% <90.00%> (+7.40%) ⬆️
access_policy.go 70.27% <100.00%> (ø)
pagination.go 100.00% <100.00%> (+28.57%) ⬆️

@jacobbednarz jacobbednarz merged commit 5bcc2d6 into cloudflare:master Jul 19, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.73.0 milestone Jul 19, 2023
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.73.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants