Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATE-4074: Adds support for the new Protocol Detection feature to teams accounts #1340

Conversation

Michael9127
Copy link
Contributor

Description

Adds support for the new ZT Account Protocol detection toggle

Has your change been tested?

Updated tests

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@Michael9127 Michael9127 force-pushed the mike/GATE-4074-add-gateway-protocol-detection-support branch from 28d6a16 to cea3365 Compare July 19, 2023 20:53
@github-actions
Copy link
Contributor

changelog detected ✅

@@ -62,6 +63,10 @@ type TeamsTLSDecrypt struct {
Enabled bool `json:"enabled"`
}

type TeamsProtocolDetection struct {
Enabled bool `json:"enabled"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do recommend all booleans as pointers but up to you folks - https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans

@jacobbednarz jacobbednarz merged commit c6c0930 into cloudflare:master Jul 20, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.74.0 milestone Jul 20, 2023
github-actions bot pushed a commit that referenced this pull request Jul 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This functionality has been released in v0.74.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants