Fix CreateOrUpdate needs the record name #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
frankywahl
force-pushed
the
fix-create-or-update
branch
from
998d604
to
508092b
Compare
For now, it was failing because we were not passing the name to the record to be created if it was not present.
frankywahl
force-pushed
the
fix-create-or-update
branch
from
508092b
to
b0ecaf3
Compare
frankywahl
commented
Jul 20, 2023
| rr.Proxied = &proxy | ||
| rr.Priority = &priority | ||
| rr := cloudflare.CreateDNSRecordParams{ | ||
| Name: name, |
There was a problem hiding this comment.
Changed the initialisation to make it match the dnsCreate method. The key change to fix the bug is line 118, now because the name was not being sent to create which would create a DNS Validation Error (1004)
frankywahl
commented
Jul 20, 2023
| Proxied: &proxy, | ||
| Priority: &priority, | ||
| } | ||
|
|
||
| // TODO: Print the response. |
There was a problem hiding this comment.
I think this TODO (see writeTable function call below) can be removed - but is unrelated to this PR.
.changelog/1341.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:bug | |||
| dns: allow for create or update to actually create the record | |||
There was a problem hiding this comment.
Suggested change
| dns: allow for create or update to actually create the record | |
| flarectl: allow for create or update to actually create the record |
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
+ Coverage 48.33% 48.42% +0.08%
==========================================
Files 133 134 +1
Lines 13023 13104 +81
==========================================
+ Hits 6295 6345 +50
- Misses 5201 5220 +19
- Partials 1527 1539 +12
|
|
This functionality has been released in v0.74.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, it was failing because we were not passing the name to the record to be created if it was not present.
Description
Make the CLI act as expected in
create-or-updatewhen no records are foundHas your change been tested?
Yes - ran it against a host I have
Types of changes
Checklist:
and relies on stable APIs.