Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispatch API path #1345

Merged
merged 1 commit into from Aug 1, 2023
Merged

Conversation

slester
Copy link
Contributor

@slester slester commented Aug 1, 2023

Description

As per the API documentation, the path should have /dispatch when deploying to the namespaced dispatch API.

Otherwise, we had the following error:

error uploading worker '123-456-abcdefghi': PUT method not allowed for the api_token authentication scheme (10000)

Upon adding /dispatch into the URL, we got successful responses.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@slester
Copy link
Contributor Author

slester commented Aug 1, 2023

CC: @aaronlisman

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #1345 (504d02a) into master (b9ac804) will increase coverage by 0.15%.
Report is 84 commits behind head on master.
The diff coverage is 58.26%.

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
+ Coverage   48.33%   48.49%   +0.15%     
==========================================
  Files         133      135       +2     
  Lines       13023    13203     +180     
==========================================
+ Hits         6295     6403     +108     
- Misses       5201     5248      +47     
- Partials     1527     1552      +25     
Files Changed Coverage Δ
access_application.go 72.72% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
device_posture_rule.go 61.80% <ø> (ø)
load_balancing.go 59.40% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
regional_tiered_cache.go 43.75% <43.75%> (ø)
logpush.go 51.81% <46.15%> (-0.30%) ⬇️
images.go 44.70% <47.82%> (-0.12%) ⬇️
access_custom_page.go 48.27% <48.27%> (ø)
rulesets.go 30.03% <52.17%> (-4.61%) ⬇️
... and 6 more

@jacobbednarz jacobbednarz merged commit 0a82ee6 into cloudflare:master Aug 1, 2023
20 checks passed
@github-actions github-actions bot added this to the v0.74.0 milestone Aug 1, 2023
@slester slester deleted the fix-dispatch-api branch August 1, 2023 23:51
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This functionality has been released in v0.74.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants