Align phases and actions with those provided by Rulesets API #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
zakcutner
force-pushed
the
zak/rulesets-phases-actions
branch
from
bb3c7e9
to
52e6cc1
Compare
zakcutner
commented
Aug 9, 2023
Comment on lines
+17
to
+23
| ```release-note:breaking-change | ||
| rulesets: Rename `RulesetPhaseRateLimit` to `RulesetPhaseHTTPRatelimit`, to match the phase name | ||
| ``` | ||
|
|
||
| ```release-note:breaking-change | ||
| rulesets: Rename `RulesetPhaseSuperBotFightMode` to `RulesetPhaseHTTPRequestSBFM`, to match the phase name | ||
| ``` |
There was a problem hiding this comment.
I made these changes just to be consistent with the names of the other phase types. @jacobbednarz we can revert this part if you think it's too much of a breaking change
There was a problem hiding this comment.
nope, that's perfect, thanks!
* Remove the `allow` action, since this does not exist. * Add the `ddos_mitigation` action. * Remove the `http_request_main` phase, since this does not exist. * Remove the `http_response_headers_transform_managed` and `http_request_late_transform_managed` phases, since they are not exposed publicly. The Managed Transforms API can be used to configure managed transforms. * Rename `RulesetPhaseRateLimit` and `RulesetPhaseSuperBotFightMode` to be consistent with the phase names.
zakcutner
force-pushed
the
zak/rulesets-phases-actions
branch
from
52e6cc1
to
5d05a1d
Compare
|
This functionality has been released in v0.75.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort phase and actions types in alphabetical order.
Remove the
allowaction, since this does not exist.Add the
ddos_mitigationaction.Remove the
http_request_mainphase, since this does not exist.Remove the
http_response_headers_transform_managedandhttp_request_late_transform_managedphases, since they are not exposed publicly. The Managed Transforms API can be used to configure managed transforms.Rename
RulesetPhaseRateLimitandRulesetPhaseSuperBotFightModeto be consistent with the phase names.Has your change been tested?
Passes existing tests, no new functionality has been introduced.
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.