Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add observatory support #1401

Merged
merged 13 commits into from Sep 15, 2023
Merged

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Sep 13, 2023

Description

Add support for Cloudflare Observatory endpoints.

Has your change been tested?

Unit test have been created matching the API endpoints spec.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.
    • public API documentation coming soon.

@github-actions
Copy link
Contributor

changelog detected ✅

observatory.go Outdated Show resolved Hide resolved
observatory.go Outdated Show resolved Hide resolved
observatory.go Outdated Show resolved Hide resolved
observatory.go Outdated Show resolved Hide resolved
observatory.go Outdated Show resolved Hide resolved
observatory.go Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

awesome start. just a few style/convention nitpicks but looking very close!

@codecov-commenter
Copy link

Codecov Report

Merging #1401 (307ddb4) into master (b9ac804) will increase coverage by 0.03%.
Report is 279 commits behind head on master.
The diff coverage is 49.74%.

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
+ Coverage   48.33%   48.37%   +0.03%     
==========================================
  Files         133      141       +8     
  Lines       13023    13978     +955     
==========================================
+ Hits         6295     6762     +467     
- Misses       5201     5528     +327     
- Partials     1527     1688     +161     
Files Changed Coverage Δ
access_audit_log.go 79.31% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
access_keys.go 71.42% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
access_service_tokens.go 51.85% <ø> (ø)
account_members.go 65.54% <ø> (ø)
account_roles.go 53.84% <ø> (ø)
accounts.go 50.81% <ø> (ø)
addressing_address_map.go 39.04% <ø> (ø)
addressing_ip_prefix.go 45.45% <ø> (ø)
... and 123 more

... and 1 file with indirect coverage changes

observatory.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 1f9672e into cloudflare:master Sep 15, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.78.0 milestone Sep 15, 2023
github-actions bot pushed a commit that referenced this pull request Sep 15, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.78.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants