Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-5428: added app launcher customization fields to access applica… #1407

Conversation

russellkerns
Copy link
Contributor

Description

This adds the ability to update the access app launcher application with customized display settings

Has your change been tested?

build the provider locally and used the fields on my own account

unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [] This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

access_application.go Outdated Show resolved Hide resolved
access_application.go Outdated Show resolved Hide resolved
@russellkerns russellkerns force-pushed the rkerns/AUTH-5428_app_launcher_customization branch from f3e4088 to f3fd20a Compare September 20, 2023 14:09
@jacobbednarz
Copy link
Member

lgtm - let me know when this lands in the API schemas and we can merge this.

@russellkerns
Copy link
Contributor Author

lgtm - let me know when this lands in the API schemas and we can merge this.

@jacobbednarz this is in the api schemas now! should be good to go

@jacobbednarz jacobbednarz merged commit 64b75d7 into cloudflare:master Oct 12, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.80.0 milestone Oct 12, 2023
github-actions bot pushed a commit that referenced this pull request Oct 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.80.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants