Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect data type in UpdateCustomNameserverZoneMetadataParams #1410

Merged
merged 4 commits into from Oct 2, 2023

Conversation

rwhelan
Copy link
Contributor

@rwhelan rwhelan commented Sep 26, 2023

Description

Incorrect data type in UpdateCustomNameserverZoneMetadataParams struct. Using as-is would return a 500.

the ns_set field is an int but the struct is currently setup with a string

Has your change been tested?

Found out the API would not accept the request without being an int.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

.changelog/1410.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit daee01d into cloudflare:master Oct 2, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.79.0 milestone Oct 2, 2023
@jacobbednarz
Copy link
Member

thanks for this @rwhelan ✌️

github-actions bot pushed a commit that referenced this pull request Oct 2, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.79.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants