Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session_duration to access policies & orgs #1415

Merged
merged 2 commits into from Oct 11, 2023

Conversation

GreenStage
Copy link
Contributor

Description

Pending documentation update
Adds session_duration to access policies & organizations.
The API already supports these, but they are undocumented

Has your change been tested?

Unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [X ] My code follows the code style of this project.
  • [ X] My change requires a change to the documentation.
  • [ X] I have updated the documentation accordingly.
  • [X ] I have added tests to cover my changes.
  • [X ] All new and existing tests passed.
  • [X ] This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

changelog detected ✅

@GreenStage GreenStage force-pushed the egomes/session branch 2 times, most recently from 6825f3e to 7c89e7f Compare October 6, 2023 13:09
@jacobbednarz
Copy link
Member

lgtm once the API schemas are updated 🏆

@jacobbednarz jacobbednarz added this to the v0.79.0 milestone Oct 11, 2023
@jacobbednarz jacobbednarz merged commit ceb9bd1 into cloudflare:master Oct 11, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.79.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants