Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per_hostname_tls_settings: correct handling of query parameters #1440

Merged
merged 2 commits into from Nov 14, 2023

Conversation

jacobbednarz
Copy link
Member

Updates the handling of the query parameters to be fed through buildURI and actually use the url struct tags.

This fixes a bug upstream in the terraform provider where the sorting isn't being applied and you get the wrong identifier forcing a replacement.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

changelog detected ✅

Updates the handling of the query parameters to be fed through
`buildURI` and actually use the `url` struct tags.

This fixes a bug upstream in the Terraform provider where the sorting
isn't being applied and you get the wrong identifier forcing a
replacement.
@jacobbednarz jacobbednarz merged commit a105059 into master Nov 14, 2023
11 checks passed
@jacobbednarz jacobbednarz deleted the put-query-params-into-url branch November 14, 2023 03:14
github-actions bot pushed a commit that referenced this pull request Nov 14, 2023
@github-actions github-actions bot added this to the v0.82.0 milestone Nov 14, 2023
Copy link
Contributor

This functionality has been released in v0.82.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant