Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for virtual network id in origin #1441

Merged
merged 4 commits into from Nov 16, 2023

Conversation

yuh-indeed
Copy link
Contributor

@yuh-indeed yuh-indeed commented Nov 14, 2023

Description

Add support to virtual_network_id listed in CloudFlare API doc here: https://developers.cloudflare.com/api/operations/account-load-balancer-pools-create-pool as the current golang client does not support this field.

Has your change been tested?

Yes, confirmed test passed and existing functionality not affected

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

changelog detected ✅

load_balancing.go Outdated Show resolved Hide resolved
yuh-indeed and others added 2 commits November 14, 2023 18:26
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@yuh-indeed
Copy link
Contributor Author

@jacobbednarz Updated the variable name, please take a look and merge if possible, thanks a lot!

@jacobbednarz jacobbednarz merged commit 05ffe97 into cloudflare:master Nov 16, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.82.0 milestone Nov 16, 2023
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
Copy link
Contributor

This functionality has been released in v0.82.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants