Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Healthy field to Load Balancer Pool struct #1442

Merged
merged 1 commit into from Nov 17, 2023

Conversation

Ltadrian
Copy link

Description

Add support to LoadBalancerPool struct by adding healthy field. In api response to the pool endpoints I see that healthy field is available but not in the cloudflare-go library.

Has your change been tested?

Added unit test

Screenshots (if appropriate):

Types of changes

Add field to struct

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [] This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Nov 15, 2023

changelog detected ✅

@Ltadrian
Copy link
Author

@jacobbednarz would you know whats wrong with changelog check failing?

@jacobbednarz
Copy link
Member

the PR number here is 1442 however the changelog is one behind at 1441. if you update the filename, the changelog checker will be happy.

@Ltadrian
Copy link
Author

Thank you that worked!

load_balancing.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 46b7c66 into cloudflare:master Nov 17, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.82.0 milestone Nov 17, 2023
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
Copy link
Contributor

This functionality has been released in v0.82.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants