Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for river and pingora frontend issues #187

Open
drcaramelsyrup opened this issue Apr 5, 2024 · 2 comments
Open

Guidelines for river and pingora frontend issues #187

drcaramelsyrup opened this issue Apr 5, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@drcaramelsyrup
Copy link
Contributor

It'd be nice to have clearer guidelines that indicate the division of responsibilities between river (a pingora "frontend" that compiles into an actual binary) and pingora (the core framework). We've been directing folks' issues to river when it makes sense.

Some classes of features such as no/low-code configuration are already set to belong in river rather than pingora, but other cases may be less clear. For example, some features like Kubernetes ingress implementations per #41 are almost certainly destined for river and not core pingora, but the river implementation may generate a feature request for pingora; the exact division of code might not be clear until design time.

This is a tracking and discussion issue for what those clearer guidelines should be and where to describe them. The ideal outcome is that we minimize confusion and issue redirection between the two projects.

@drcaramelsyrup drcaramelsyrup added the documentation Improvements or additions to documentation label Apr 5, 2024
@drcaramelsyrup
Copy link
Contributor Author

cc @jamesmunns

@jamesmunns
Copy link
Contributor

Thanks @drcaramelsyrup!

I think there's a couple main things to discuss at some point:

  1. Making the distinction between "frontends" like River and "the backend" of pingora more clear (and maybe agreeing on where to draw the lines?)
  2. Unwinding some code/architectural decisions to make pingora more "friendly" to different frontends
  3. Communicating these things up front in the pingora and river repos

WRT 1 + 2: this would be things like removing configuration handling, and maybe things like signal handlers from pingora itself, and instead lean on library APIs and methods that can be used to trigger those actions or provide config.

I'm happy to keep giving feedback as I go, or have a chat/call sometime.

WRT 3: I think once we get on the same page, it'd be good to just write it down in the docs, and link it in both repos. No need for crazy formalism :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants