Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D1 support #1687

Merged
merged 11 commits into from Sep 26, 2022
Merged

D1 support #1687

merged 11 commits into from Sep 26, 2022

Conversation

geelen
Copy link
Contributor

@geelen geelen commented Aug 16, 2022

This adds wrangler d1 subcommand, that's been being tested on the wrangler@d1 tag:

wrangler d1

🗄  Interact with a D1 database

Commands:
  wrangler d1 list            List D1 databases
  wrangler d1 create <name>   Create D1 database
  wrangler d1 delete <name>   Delete D1 database
  wrangler d1 backup          Interact with D1 Backups
  wrangler d1 execute <name>  Executed command or SQL file

Flags:
  -c, --config   Path to .toml configuration file  [string]
  -h, --help     Show help  [boolean]
  -v, --version  Show version number  [boolean]

At the moment it uses a prerelease version of miniflare, "2.8.2-d1.0", but that will be released properly soon and I'll update this PR.

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

🦋 Changeset detected

Latest commit: 200c7f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3127583359/npm-package-wrangler-1687

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1687/npm-package-wrangler-1687

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3127583359/npm-package-wrangler-1687 dev path/to/script.js

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1687 (200c7f2) into main (b829c9c) will decrease coverage by 2.03%.
The diff coverage is 37.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   77.62%   75.58%   -2.04%     
==========================================
  Files         105      116      +11     
  Lines        7480     7855     +375     
  Branches     1974     2044      +70     
==========================================
+ Hits         5806     5937     +131     
- Misses       1674     1918     +244     
Impacted Files Coverage Δ
packages/wrangler/src/api/dev.ts 69.23% <ø> (ø)
packages/wrangler/src/dialogs.tsx 25.45% <0.00%> (-0.97%) ⬇️
packages/wrangler/src/user/user.tsx 70.44% <ø> (ø)
packages/wrangler/src/d1/execute.tsx 16.52% <16.52%> (ø)
packages/wrangler/src/d1/utils.ts 20.00% <20.00%> (ø)
packages/wrangler/src/bundle.ts 84.33% <22.22%> (-3.57%) ⬇️
packages/wrangler/src/d1/backups.tsx 26.31% <26.31%> (ø)
packages/wrangler/src/d1/list.tsx 30.76% <30.76%> (ø)
packages/wrangler/src/d1/options.ts 33.33% <33.33%> (ø)
packages/wrangler/src/d1/delete.tsx 34.78% <34.78%> (ø)
... and 18 more

@geelen geelen changed the title D1 support (WIP) D1 support Sep 13, 2022
@geelen geelen marked this pull request as ready for review September 13, 2022 12:43
@GregBrimble
Copy link
Member

We've found fixtures to be really great. Might be a bit of effort to set up with a sqlite file, but if there's going to be a chunky refactor for when it D1 GA's, it very well might be worth it.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interim comments - haven't looked at the D1 folder yet.

packages/pages-shared/package.json Outdated Show resolved Hide resolved
packages/wrangler/package.json Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/helpers/mock-istty.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/paths.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/dev.tsx Show resolved Hide resolved
packages/wrangler/package.json Outdated Show resolved Hide resolved
packages/wrangler/src/bundle.ts Outdated Show resolved Hide resolved
packages/wrangler/src/cfetch/internal.ts Show resolved Hide resolved
packages/wrangler/src/config/index.ts Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/helpers/mock-istty.ts Outdated Show resolved Hide resolved
packages/wrangler/src/cfetch/internal.ts Show resolved Hide resolved
@geelen geelen merged commit 28cd736 into main Sep 26, 2022
@geelen geelen deleted the d1 branch September 26, 2022 12:59
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants