Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all accessible ports on remote mode dev #1881

Merged

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Sep 18, 2022

Closes #1652
Uses borrowed logic from miniflare

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2022

🦋 Changeset detected

Latest commit: 1c699d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3083726244/npm-package-wrangler-1881

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1881/npm-package-wrangler-1881

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3083726244/npm-package-wrangler-1881 dev path/to/script.js

Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions, non blocking.

packages/wrangler/src/proxy.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #1881 (1c699d1) into main (d8fe95d) will increase coverage by 0.48%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
+ Coverage   76.89%   77.38%   +0.48%     
==========================================
  Files         104      105       +1     
  Lines        7341     7485     +144     
  Branches     1928     1976      +48     
==========================================
+ Hits         5645     5792     +147     
+ Misses       1696     1693       -3     
Impacted Files Coverage Δ
packages/wrangler/src/proxy.ts 17.85% <7.69%> (-0.63%) ⬇️
packages/wrangler/src/pages/dev.tsx 21.71% <0.00%> (-1.24%) ⬇️
packages/wrangler/src/pages/publish.tsx 62.57% <0.00%> (-0.46%) ⬇️
packages/wrangler/src/inspect.ts 5.53% <0.00%> (-0.09%) ⬇️
packages/wrangler/src/pages/constants.ts 100.00% <0.00%> (ø)
...ngler/src/pages/functions/routes-transformation.ts 100.00% <0.00%> (ø)
.../wrangler/src/pages/functions/routes-validation.ts 92.42% <0.00%> (ø)
packages/wrangler/src/dev.tsx 85.37% <0.00%> (+0.47%) ⬆️
packages/wrangler/src/pages/functions.tsx 54.83% <0.00%> (+3.22%) ⬆️
packages/wrangler/src/dev/start-server.ts 76.00% <0.00%> (+3.58%) ⬆️
... and 3 more

@Skye-31 Skye-31 force-pushed the chore/remote-mode-ports-available branch from 599ab75 to 34ef793 Compare September 18, 2022 18:17
@GregBrimble
Copy link
Member

FYI, I've just put up a PR against Miniflare to fix a small bug related to the code you've copied: cloudflare/miniflare#382

Not sure if it affects you here, but worth testing.

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make the comment from Greg a requirement before merging #1881 (comment)

@Skye-31 Skye-31 requested review from JacobMGEvans and removed request for petebacondarwin September 19, 2022 15:41
@Skye-31
Copy link
Contributor Author

Skye-31 commented Sep 19, 2022

Good catch, resolved

@cameron-robey
Copy link
Contributor

(Provided tests pass) I'm going to merge this in now

Doesn't look like we have proxy server tests? Maybe this is something we should address...

@cameron-robey cameron-robey merged commit 6ff5a03 into cloudflare:main Sep 26, 2022
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
@Skye-31 Skye-31 deleted the chore/remote-mode-ports-available branch September 26, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: default 0.0.0.0 wrangler dev address not routable in Windows
5 participants