New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log all accessible ports on remote mode dev #1881
Log all accessible ports on remote mode dev #1881
Conversation
🦋 Changeset detectedLatest commit: 1c699d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3083726244/npm-package-wrangler-1881 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1881/npm-package-wrangler-1881 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3083726244/npm-package-wrangler-1881 dev path/to/script.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions, non blocking.
Codecov Report
@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
+ Coverage 76.89% 77.38% +0.48%
==========================================
Files 104 105 +1
Lines 7341 7485 +144
Branches 1928 1976 +48
==========================================
+ Hits 5645 5792 +147
+ Misses 1696 1693 -3
|
599ab75
to
34ef793
Compare
FYI, I've just put up a PR against Miniflare to fix a small bug related to the code you've copied: cloudflare/miniflare#382 Not sure if it affects you here, but worth testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make the comment from Greg a requirement before merging #1881 (comment)
Good catch, resolved |
(Provided tests pass) I'm going to merge this in now Doesn't look like we have proxy server tests? Maybe this is something we should address... |
Closes #1652
Uses borrowed logic from miniflare