Initial --experimental-local implementation using Miniflare 3
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: cd9ef56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
penalosa
requested changes
Sep 26, 2022
|
@mrbbot couple of small things, but looks good! |
Co-authored-by: Somhairle MacLe貌id <samuel@macleod.space>
`workerd` currently throws on any use of the Cache API. Workers Sites requires the Cache API to function though, so stub it out to no-ops, like in regular `wrangler dev`.
These should've been caught/logged earlier.
# Conflicts: # package-lock.json # packages/wrangler/package.json # packages/wrangler/src/dev/local.tsx # packages/wrangler/src/publish.ts
cameron-robey
approved these changes
Sep 27, 2022
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3135850931/npm-package-wrangler-1894You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1894/npm-package-wrangler-1894Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3135850931/npm-package-wrangler-1894 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3135850931/npm-package-cloudflare-pages-shared-1894 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP implementation of an
--experimental-localflag that uses a version of Miniflare powered by the open-source runtime. There are a few small TODOs still to resolve, but other than that... 馃檪