New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use node http instead of faye-websocket in proxy server #1930
Conversation
🦋 Changeset detectedLatest commit: 6fe426f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3142085026/npm-package-wrangler-1930 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1930/npm-package-wrangler-1930 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3142085026/npm-package-wrangler-1930 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3142085026/npm-package-cloudflare-pages-shared-1930 |
Codecov Report
@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
- Coverage 75.26% 75.09% -0.18%
==========================================
Files 116 116
Lines 7896 7922 +26
Branches 2055 2062 +7
==========================================
+ Hits 5943 5949 +6
- Misses 1953 1973 +20
|
We really should make it so that we don't have to rerun tests after updating the changeset... |
c250624
to
60dbecc
Compare
Could be doable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of nits, but 👍. We were going to use a similar WebSocket proxying mechanism in Miniflare 3, and it's possible @penalosa made some additional changes. Worth checking there's nothing we're missing. 🙂
Co-authored-by: MrBBot <bcoll@cloudflare.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1767
Closes #1812
Closes #1813