Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node http instead of faye-websocket in proxy server #1930

Merged
merged 9 commits into from Sep 28, 2022

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Sep 27, 2022

Closes #1767
Closes #1812
Closes #1813

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: 6fe426f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3142085026/npm-package-wrangler-1930

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1930/npm-package-wrangler-1930

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3142085026/npm-package-wrangler-1930 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.developers.workers.dev/runs/3142085026/npm-package-cloudflare-pages-shared-1930

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1930 (6fe426f) into main (452b84b) will decrease coverage by 0.17%.
The diff coverage is 4.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
- Coverage   75.26%   75.09%   -0.18%     
==========================================
  Files         116      116              
  Lines        7896     7922      +26     
  Branches     2055     2062       +7     
==========================================
+ Hits         5943     5949       +6     
- Misses       1953     1973      +20     
Impacted Files Coverage Δ
packages/wrangler/src/proxy.ts 16.58% <4.34%> (-1.27%) ⬇️
packages/wrangler/src/dev/local.tsx 27.31% <0.00%> (-0.49%) ⬇️
packages/wrangler/src/module-collection.ts 97.36% <0.00%> (+0.14%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@cameron-robey cameron-robey changed the title fix: pass protocols from headers fix: use node http instead of faye-websocket in proxy server Sep 27, 2022
@cameron-robey
Copy link
Contributor

We really should make it so that we don't have to rerun tests after updating the changeset...

@JacobMGEvans
Copy link
Contributor

We really should make it so that we don't have to rerun tests after updating the changeset...

Could be doable.

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple of nits, but 👍. We were going to use a similar WebSocket proxying mechanism in Miniflare 3, and it's possible @penalosa made some additional changes. Worth checking there's nothing we're missing. 🙂

packages/wrangler/src/proxy.ts Outdated Show resolved Hide resolved
packages/wrangler/src/proxy.ts Outdated Show resolved Hide resolved
Co-authored-by: MrBBot <bcoll@cloudflare.com>
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rozenmd rozenmd merged commit 5679815 into main Sep 28, 2022
@rozenmd rozenmd deleted the handle-websockets-dev branch September 28, 2022 09:27
@github-actions github-actions bot mentioned this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants